Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SauceTunnel: "direct-domains" are not comma-separated #6

Closed
vladikoff opened this issue Aug 4, 2014 · 4 comments
Closed

SauceTunnel: "direct-domains" are not comma-separated #6

vladikoff opened this issue Aug 4, 2014 · 4 comments
Labels

Comments

@vladikoff
Copy link
Member

Ref: https://docs.saucelabs.com/reference/sauce-connect/#command-line-options

Currently the SauceTunnel does not comma separate, but space separates the domains:

image

@csnover
Copy link
Member

csnover commented Aug 4, 2014

The documentation you link, as well as sc --help, specify that the argument is to be comma-separated, which is what Dig Dug does. “Comma-separated list of domains.” This has been true back to Sauce Connect 3. If Sauce Connect 4 is not accepting a comma-separated list, then it is a bug in Sauce Connect 4 that needs to be fixed there.

@csnover csnover closed this as completed Aug 4, 2014
@csnover csnover added the invalid label Aug 4, 2014
@vladikoff
Copy link
Member Author

You can see from my screenshot that part of the command is

-D latest.dev.lcip.org [SPACE] restmail.net

shouldn't that be:

-D latest.dev.lcip.org,restmail.net

Maybe I'm misunderstanding something

@csnover
Copy link
Member

csnover commented Aug 5, 2014

Dig Dug does comma-separate the list of direct domains:

this.directDomains.length && args.push('-D', this.directDomains.join(','));

This report sounded to me like Sauce Connect expected a space-separated list, which is what my response was trying to address, since the code already generates a comma-separated list.

Without a reduced set of reproduction steps, expected results, and actual results, it is very difficult to understand what is actually being reported, so I will guess blindly and incorrectly much of the time in such cases. To minimise confusion, please make sure to try to provide them for all issues in future. Thanks!

@vladikoff
Copy link
Member Author

Dig Dug does comma-separate the list of direct domains:

Yeah saw that in the source, but I wonder why the resulting process has it space separated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants