Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update state plotting #1177

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Conversation

WeilerP
Copy link
Member

@WeilerP WeilerP commented Mar 14, 2024

IMPORTANT: Please search among the Pull requests before creating one.

Description

  • Updates state plotting to show outline.

Closes

Closes #1176.

Add outline if plotted in same plot.
Update ground truth figures for unit tests using
new API.
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.78%. Comparing base (4ae88b9) to head (b4c2dc7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1177      +/-   ##
==========================================
+ Coverage   80.77%   80.78%   +0.01%     
==========================================
  Files          51       51              
  Lines        8607     8612       +5     
  Branches     2237     2237              
==========================================
+ Hits         6952     6957       +5     
  Misses       1102     1102              
  Partials      553      553              
Files Coverage Δ
...timators/terminal_states/_term_states_estimator.py 77.31% <100.00%> (+0.39%) ⬆️

@WeilerP WeilerP requested a review from michalk8 March 14, 2024 10:04
Copy link
Collaborator

@michalk8 michalk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change, after the pass, lgtm, thank you!

Refactor adding `"nan"` as a category.
@WeilerP WeilerP merged commit 9069571 into theislab:main Mar 15, 2024
8 of 9 checks passed
@WeilerP WeilerP deleted the feat/update_state_plotting branch March 15, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plot states as in CellRank 2
2 participants