Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lineage colors agg #482

Merged
merged 7 commits into from
Feb 3, 2021
Merged

Lineage colors agg #482

merged 7 commits into from
Feb 3, 2021

Conversation

michalk8
Copy link
Collaborator

@michalk8 michalk8 commented Feb 2, 2021

IMPORTANT: Please search among the Pull request before creating one.

Title

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)

Description

How has this been tested?

Yes. It was also previously, but it passed because it testing object also used default colors.

Closes

closes #479

@michalk8 michalk8 mentioned this pull request Feb 2, 2021
3 tasks
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #482 (a802655) into master (f501b53) will increase coverage by 0.18%.
The diff coverage is 98.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
+ Coverage   88.15%   88.33%   +0.18%     
==========================================
  Files          54       53       -1     
  Lines        7360     7315      -45     
==========================================
- Hits         6488     6462      -26     
+ Misses        872      853      -19     
Flag Coverage Δ
unittests 88.33% <98.13%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cellrank/datasets/__init__.py 100.00% <ø> (ø)
cellrank/logging/__init__.py 100.00% <ø> (ø)
cellrank/logging/_logging.py 78.72% <ø> (-0.23%) ⬇️
cellrank/pl/__init__.py 100.00% <ø> (ø)
cellrank/pl/_cluster_lineage.py 86.13% <ø> (-0.14%) ⬇️
cellrank/pl/_lineages.py 90.62% <ø> (-0.29%) ⬇️
cellrank/settings/__init__.py 100.00% <ø> (ø)
cellrank/settings/_settings.py 90.00% <ø> (ø)
cellrank/tl/__init__.py 100.00% <ø> (ø)
cellrank/tl/_constants.py 96.42% <ø> (-0.05%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c424ce...a802655. Read the comment docs.

@michalk8 michalk8 merged commit cda144f into master Feb 3, 2021
@michalk8 michalk8 deleted the lineage_colors_agg branch February 3, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lineage class reduction permutes the colors
1 participant