Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/apply scale by marginals #86

Merged
merged 4 commits into from
Feb 11, 2022
Merged

Feature/apply scale by marginals #86

merged 4 commits into from
Feb 11, 2022

Conversation

michalk8
Copy link
Collaborator

closes #80

@michalk8 michalk8 added enhancement New feature or request backend Backend-related issue. labels Feb 11, 2022
@michalk8 michalk8 self-assigned this Feb 11, 2022
zoepiran
zoepiran reviewed Feb 11, 2022
View reviewed changes
Copy link
Collaborator

@zoepiran zoepiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing. two minor comments

moscot/backends/ott/_output.py Outdated Show resolved Hide resolved
moscot/solvers/_output.py Outdated Show resolved Hide resolved
@michalk8 michalk8 merged commit 3ed1b38 into dev Feb 11, 2022
@michalk8 michalk8 deleted the feature/apply-scale-by-marginals branch February 11, 2022 16:37
@michalk8 michalk8 mentioned this pull request Feb 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoepiran zoepiran zoepiran left review comments

Assignees

@michalk8 michalk8

Labels
backend Backend-related issue. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to divide by true marginals in _apply in SolverOutput
2 participants
@michalk8 @zoepiran