Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] add possibility to pass id to the FocusLock element #237

Closed
grzegorzpokorski opened this issue Jan 9, 2023 · 2 comments
Closed

[feature] add possibility to pass id to the FocusLock element #237

grzegorzpokorski opened this issue Jan 9, 2023 · 2 comments

Comments

@grzegorzpokorski
Copy link

grzegorzpokorski commented Jan 9, 2023 •
edited
Loading

It is nice that we can set which html elment should be FocusLock by provide a value in as prop - I'm very often use that to set FocusLock as a nav element. I think it would be nice to have a ability to set value for id attribute. It is necessary when you would like to set a aria-* atributes which needs an id.
@grzegorzpokorski
Copy link
Author

Oh sorry, I overlooked lockProps prop from docs 😬

@theKashey
Copy link
Owner

And probably that was for react-focus-on. No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theKashey @grzegorzpokorski