Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined method 'err' under PuppetServer 2.3.1 #23

Closed
jordigg opened this issue Apr 25, 2016 · 3 comments
Closed

Undefined method 'err' under PuppetServer 2.3.1 #23

jordigg opened this issue Apr 25, 2016 · 3 comments

Comments

@jordigg
Copy link
Contributor

jordigg commented Apr 25, 2016 •
edited
Loading

Just updated my Puppet Server to 2.3.1 and got errors on the has_brew and has_compiler facts.

error while resolving custom fact "has_brew": undefined method 'err' for #<Facter::Util::Resolution:0x0000000281b8c8>

same for has_compiler. Is it maybe that errors should be handled, for example, by:
rescue Facter::Core::Execution::ExecutionFailure 'timeout!'

Another question is, should we confine that custom_fact just to MacOSX?
confine :kernel => "Darwin"
@jordigg
Copy link
Contributor Author

jordigg commented Apr 25, 2016 •
edited
Loading

Just saw that you were already working on it on #22. What about using confine :kernel => "Darwin" to just use it on Darwin nodes?

@TheKevJames
Copy link
Owner

There was some weirdness in confine that caused #17. I'm thinking just removing the err logs makes the most sense since actually trying to run the manifest on a non-Darwin system will already throw.

@TheKevJames
Copy link
Owner

Fixed in #22, released in 1.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jordigg @TheKevJames