Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lack of Error/Confirmation message makes user think nothing has happened (in signup) #45

Closed
lunaroyster opened this issue Oct 22, 2015 · 13 comments
Closed

Lack of Error/Confirmation message makes user think nothing has happened (in signup) #45

lunaroyster opened this issue Oct 22, 2015 · 13 comments
Assignees
@thel3l

Comments

@lunaroyster
Copy link
Collaborator

No description provided.

@rithvikvibhu
Copy link
Collaborator

hmmm?
when and where?

@lunaroyster lunaroyster changed the title Lack of Error/Confirmation message makes user think nothing has happened Lack of Error/Confirmation message makes user think nothing has happened (in signup) Oct 22, 2015
@thel3l thel3l self-assigned this Oct 22, 2015
@thel3l
Copy link
Owner

thel3l commented Oct 22, 2015

Fixing.

@rithvikvibhu
Copy link
Collaborator

Ahhh. the only thing it currently does is disable all fields and button

@thel3l
Copy link
Owner

thel3l commented Oct 22, 2015

Partial fix with b50a036

@rithvikvibhu
Copy link
Collaborator

NOOOOO. that message required is "Please wait..."

@thel3l
Copy link
Owner

thel3l commented Oct 22, 2015

I said partial. And in Slack, I said " I made a mistake

@thel3l
Copy link
Owner

thel3l commented Oct 22, 2015

Hmm. Slight Q here. The sign up is instant. Which means that having the alert in

        request.always(function () {

makes sense.

@rithvikvibhu
Copy link
Collaborator

isn't that what u have done? @thel3l It should be there

@thel3l
Copy link
Owner

thel3l commented Oct 22, 2015

f0dc8a9

@rithvikvibhu
Copy link
Collaborator

Exactly. that's fine

@rithvikvibhu
Copy link
Collaborator

Finally, a working thing 2455d8b

rithvikvibhu referenced this issue Oct 24, 2015
@hackdpse
Fixed Please wait (PROPERLY)
2455d8b
@lunaroyster
Copy link
Collaborator Author

There's an error message that shows up. Also, no email

@rithvikvibhu
Copy link
Collaborator

Uhhh. Did u refresh the page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thel3l thel3l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rithvikvibhu @lunaroyster @thel3l