Add docker-build process. #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquincasares
requested review from
rustyrazorblade,
adejanovski and
michaelsembwever
This was referenced Jul 7, 2017
ossarga
reviewed
Jul 11, 2017
README.md
Outdated
| `debuild -uc -us -b` | ||
| ### Debian and RPM Packages | ||
|
|
||
| Notice that you can also build Debian and RPM packages from this project by using *Make*, for example: |
There was a problem hiding this comment.
Consider rewording this to something like
Debian and RPM packages can be built from this project using Make, for example:
| Notice that you can also build a Debian package from this project by using *debuild*, for example: | ||
| `debuild -uc -us -b` | ||
| ### Debian and RPM Packages | ||
|
|
There was a problem hiding this comment.
Consider adding a Make subheading e.g.
**Make**
README.md
Outdated
| ### Debian and RPM Packages | ||
|
|
||
| Notice that you can also build Debian and RPM packages from this project by using *Make*, for example: | ||
| `make all`. |
There was a problem hiding this comment.
Consider adding a new line between the note and the command and pace it in its own code block e.g.
```bash
make all
```
README.md
Outdated
|
|
||
| Notice that you can also build Debian and RPM packages from this project by using *Make*, for example: | ||
| `make all`. | ||
|
|
There was a problem hiding this comment.
Consider adding a Docker subheading e.g.
Docker
|
Thanks for the review @ossarga ! Merging this in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first pull request in an attempt to resolve #46, which has partially, and more accurately, been taken care of through #76.
The bulk of these changes appear in the README.
The intent of these files is to build the RPM and Debian packages without any system dependencies other than Docker.