Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flooding other clients with NAMES lists #476

Closed
wiiaam opened this issue Jul 8, 2016 · 3 comments · Fixed by #632
Closed

Flooding other clients with NAMES lists #476

wiiaam opened this issue Jul 8, 2016 · 3 comments · Fixed by #632
Assignees
Milestone

Comments

@wiiaam
Copy link

wiiaam commented Jul 8, 2016

Whenever a channel mode is changed, it is requesting the NAMES list in that channel. This isn't an issue on lounge itself, but when I have it connected to my bouncer, I am seeing names list flooding on my other clients (especially when the channel has a lot of users).

Most clients tend to update the users list with channel ranks as soon as they are spotted, and will periodically send out a WHO command to different channels to update the userlists manually, in case one was missed.

@omnicons
Copy link
Contributor

omnicons commented Jul 8, 2016

Turn on route replies in your bouncer. This isn't really a bug, you just
haven't properly enabled the feature on your own bouncer, don't blame the
client for something that's not its fault.

On Fri, Jul 8, 2016 at 5:00 AM, William Howell notifications@github.com
wrote:

Whenever a channel mode is changed, it is requesting the NAMES list in
that channel. This isn't an issue on lounge itself, but when I have it
connected to my bouncer, I am seeing names list flooding on my other
clients (especially when the channel has a lot of users).

Most clients tend to update the users list with channel ranks as soon as
they are spotted, and will periodically send out a WHO command to different
channels to update the userlists manually, in case one was missed.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#476, or mute the thread
https://github.com/notifications/unsubscribe/AGtbL-6HJhfOfJmFbWVA7wJcVEff-jhPks5qThGQgaJpZM4JH2F2
.

@wiiaam
Copy link
Author

wiiaam commented Jul 8, 2016

@omnicons but the client shouldn't be sending out NAMES requests anyway, it should just be logging the channel most when it sees it. NAMES is a user command to print the user list, it wasn't designed to be used to track channel modes by the client (it even states this in RFC 1459). This also means that until this is fixed, users are unable to use the /names command properly in the client. It would be better to use WHO instead as it is parsed in the background of pretty much every IRC client.

@omnicons
Copy link
Contributor

omnicons commented Jul 8, 2016 via email

@xPaw xPaw self-assigned this Sep 24, 2016
@xPaw xPaw added this to the Next Release milestone Sep 24, 2016
@xPaw xPaw modified the milestones: 2.1.0, Next Release Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants