Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align message container to the bottom #1787

Merged
merged 1 commit into from
Dec 16, 2017
Merged

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Dec 1, 2017

Fixes message jumping when all the messages are visible without a scrollbar and new messages load in (if there are 90 condensed messages, there are only a couple of lines visible). Also makes it much nicer with lazy-init when there's only 1 message visible.

This pretty much matches behaviour of other chat apps where they begin stacking from the bottom.

01-104224060

@xPaw xPaw added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Dec 1, 2017
@xPaw xPaw added this to the 2.7.0 milestone Dec 1, 2017
@xPaw xPaw requested a review from astorije December 3, 2017 19:55
Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying it locally, it feels super weird to me lol, but it's probably > 80% because I'm used to the current way.
Objectively speaking, the advantages sound reasonable and I don't see any red flags UX-wise.
Let's give it a chance and see how it's received :)

@astorije astorije merged commit ffe8f28 into master Dec 16, 2017
@astorije astorije deleted the xpaw/messages-bottom branch December 16, 2017 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants