Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make context menus accessible with keyboard #2377

Merged
merged 3 commits into from Jun 19, 2018
Merged

Make context menus accessible with keyboard #2377

merged 3 commits into from Jun 19, 2018

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Apr 22, 2018 •
edited

  • Each context menu item is focusable
  • Each context menu can be opened with enter
  • Can navigate menu with up/down arrows
  • Context menu events must be bound only once (currently they are bound every time context menu opens, bug on master too)
  • When escaping context menu opening in user list, return focus to the search field. Now it returns focus to previous element.

@xPaw xPaw added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Apr 22, 2018
@xPaw xPaw added this to the 3.0.0 milestone Apr 22, 2018
@xPaw xPaw added this to Todo in Accessibility via automation Apr 22, 2018
@xPaw xPaw force-pushed the xpaw/contextmenu-keyboard branch 2 times, most recently from 01266f6 to d253aee Compare April 22, 2018 14:37
@xPaw xPaw added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Apr 22, 2018
@xPaw xPaw force-pushed the xpaw/contextmenu-keyboard branch from d253aee to 9fe0d24 Compare April 22, 2018 17:47
@astorije astorije self-requested a review April 24, 2018 04:58
@xPaw xPaw force-pushed the xpaw/contextmenu-keyboard branch from 151d0ff to 647323f Compare May 3, 2018 10:08
@xPaw xPaw force-pushed the xpaw/contextmenu-keyboard branch from 647323f to f09c86c Compare May 10, 2018 14:20
@xPaw xPaw requested a review from AlMcKinlay May 14, 2018 13:08
astorije
astorije approved these changes May 25, 2018
View reviewed changes
Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind removing the focus ring for now? It's pretty atrocious right now :s
We can make this nicer and more obvious as part of #1873 (or separately).

@xPaw
Copy link
Member Author

xPaw commented May 25, 2018

@astorije I left them as is precisely because of #1873.

@astorije
Copy link
Member

@xPaw, they're really ugly here though. I'd rather remove the outline for now, since there is a background color already. 🙏

@xPaw xPaw force-pushed the xpaw/contextmenu-keyboard branch from f09c86c to 714d365 Compare May 26, 2018 08:17
@xPaw xPaw force-pushed the xpaw/contextmenu-keyboard branch from 714d365 to 03a7d97 Compare June 10, 2018 08:53
xPaw and others added 3 commits June 15, 2018 13:27
@xPaw
Make context menus accessible with keyboard
d178ac9
@xPaw
Add role attributes in context menus
012ca80
@xPaw
Remove unnecessary code
2453153 
This cause context menu to re-open when clicking on user in the context menu
@xPaw xPaw force-pushed the xpaw/contextmenu-keyboard branch from a9644b7 to 2453153 Compare June 15, 2018 10:28
@astorije
Copy link
Member

Alright, merging this to put it in a pre-release. If something breaks, we'll see it there.

@astorije astorije merged commit 0be8de7 into master Jun 19, 2018
Accessibility automation moved this from Todo to Done Jun 19, 2018
@astorije astorije deleted the xpaw/contextmenu-keyboard branch June 19, 2018 04:23
@astorije astorije mentioned this pull request Jun 19, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorije astorije astorije approved these changes

@AlMcKinlay AlMcKinlay Awaiting requested review from AlMcKinlay

Assignees

@AlMcKinlay AlMcKinlay

Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
Accessibility
  
Done
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xPaw @astorije @AlMcKinlay