Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a ghost placeholder when dragging channels #2405

Merged
merged 1 commit into from
May 2, 2018
Merged

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented May 1, 2018

I think it provides a better UI.

01-081920050

@xPaw xPaw added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label May 1, 2018
@astorije
Copy link
Member

astorije commented May 2, 2018

@xPaw, no offense but... that's not pretty :D :D

I tried a couple things (including a skeleton placeholder which... didn't go well lol) and I think the following works well:

channel_list_sorting

What do you think?

The GIF doesn't show it well, but it's a dotted border, similar to this example.
The diff to get there:

Diff
diff --git a/client/css/style.css b/client/css/style.css
index 37bc17f2..a3f5a5f9 100644
--- a/client/css/style.css
+++ b/client/css/style.css
@@ -542,6 +542,13 @@ kbd {
 	display: none;
 }

+#sidebar .network-placeholder,
+#sidebar .chan-placeholder {
+	border: 1px dotted #99a2b4;
+	border-radius: 4px;
+	margin: -1px 10px;
+}
+
 #sidebar .network,
 #sidebar .network-placeholder {
 	position: relative;
@@ -549,6 +556,10 @@ kbd {
 	touch-action: pan-y;
 }

+#sidebar .network-placeholder {
+	margin-bottom: 29px;
+}
+
 #sidebar .empty {
 	flex-grow: 1;
 	line-height: 1.6;
@@ -561,7 +572,6 @@ kbd {
 	display: flex;
 	padding: 8px 14px;
 	transition: color 0.2s;
-	width: 100%;
 }

 #sidebar .chan.lobby {

@xPaw
Copy link
Member Author

xPaw commented May 2, 2018

@astorije used your method, except I used dashed style because it's doesn't blend in as much.

Co-Authored-By: Jérémie Astori <astorije@users.noreply.github.com>
@xPaw xPaw changed the title Display an arrow where sorted channel will be inserted Show a ghost placeholder when dragging channels May 2, 2018
@xPaw xPaw added this to the 3.0.0 milestone May 2, 2018
@xPaw xPaw merged commit 1e5e9bb into master May 2, 2018
@xPaw xPaw deleted the xpaw/sort-arrow branch May 2, 2018 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants