Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop handling CTCP messages if the sender/target is ignored #2609

Merged
merged 1 commit into from
Jul 7, 2018
Merged

Stop handling CTCP messages if the sender/target is ignored #2609

merged 1 commit into from
Jul 7, 2018

Conversation

Xinayder
Copy link
Contributor

@Xinayder Xinayder commented Jul 1, 2018

Closes #2597

@astorije
Copy link
Member

astorije commented Jul 1, 2018

I think this looks good, but I'll let @xPaw give a first review as I believe he gave you some directions and I don't want to step on his toes :)

@astorije astorije requested a review from xPaw July 1, 2018 21:39
@xPaw
Copy link
Member

xPaw commented Jul 1, 2018

Code looks OK, but I didn't test it.

@xPaw xPaw added this to the 3.0.0 milestone Jul 3, 2018
@xPaw xPaw added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Jul 7, 2018
@xPaw xPaw merged commit 95e6fb3 into thelounge:master Jul 7, 2018
@xPaw xPaw added Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. and removed Type: Feature Tickets that describe a desired feature or PRs that add them to the project. labels Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xPaw xPaw xPaw approved these changes

Assignees
No one assigned
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Xinayder @astorije @xPaw