Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "!" modechar for admin #354

Merged
merged 1 commit into from
May 31, 2016
Merged

Add "!" modechar for admin #354

merged 1 commit into from
May 31, 2016

Conversation

omnicons
Copy link
Contributor

For the odd network out that uses it!

For the odd network out that uses it!
@maxpoulin64 maxpoulin64 added Type: Feature Tickets that describe a desired feature or PRs that add them to the project. second review needed labels May 28, 2016
@maxpoulin64
Copy link
Member

23:10   Dusk    Is there any plan to support  alternate modechars here btw?
23:11   +Max-P  What's that?
23:11   Dusk    well the standard set of mode characters are ~&@%+
23:11   +Max-P  Ah, that
23:11   Dusk    but as a person who uses and helps run the elemental test network; elemental uses ~!@%+

As I expressed on IRC, we still have no way of knowing what names are attached to those modes, but since it's the only difference I think it's fine to add this one to our hardcoded list. 👍

@dgw
Copy link
Contributor

dgw commented May 28, 2016

Oh how I long for PREFIX parsing.

@maxpoulin64
Copy link
Member

@dgw: we do parse PREFIX. This is purely for the fancy names on the user list.

@dgw
Copy link
Contributor

dgw commented May 28, 2016

Hmm… My mistake. I guess there's no ISUPPORT value for those.

@astorije
Copy link
Member

I think I'm 👍, but I would prefer to have @xPaw's input on this.

@xPaw
Copy link
Member

xPaw commented May 30, 2016

Yeah I don't know where ! came from. I would like to see at least a couple of networks using it before merging this.

@astorije
Copy link
Member

@xPaw, I think the OP (or someone else) mentioned 2-3 networks that need this: the elemental ircd test network, ponychat, and another one I forgot.
What do you think?

@xPaw xPaw merged commit 12760a8 into thelounge:master May 31, 2016
@xPaw xPaw added this to the 2.0.0 milestone May 31, 2016
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
snowfudge added a commit to snowfudge/thelounge that referenced this pull request Feb 20, 2024
- Also added back "!" based on PR thelounge#354 for the "odd network" that uses it (by omnicons)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants