Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bootstrap.css, use flexbox #3574

Merged
merged 6 commits into from
Dec 14, 2019
Merged

Remove bootstrap.css, use flexbox #3574

merged 6 commits into from
Dec 14, 2019

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Dec 12, 2019 •
edited
Loading

  • Remove bootstrap.css (we mostly used normalize.css and grid from it)
  • Use normalize.css as a npm package so it stays up to date
  • Removes all uses of float - it's all flexbox now

Fixes #638.

View the diff with whitespace changes hidden.

@xPaw xPaw added the Meta: Internal This is an internal codebase change (testing, linting, etc.). label Dec 12, 2019
@xPaw xPaw added this to the 4.0.0 milestone Dec 12, 2019
richrd
richrd requested changes Dec 14, 2019
View reviewed changes
client/components/Windows/Settings.vue Outdated Show resolved Hide resolved
@richrd richrd self-requested a review December 14, 2019 20:35
@xPaw xPaw merged commit ead372e into master Dec 14, 2019
@xPaw xPaw deleted the xpaw/normalize.css branch December 14, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richrd richrd richrd approved these changes

Assignees
No one assigned
Labels
Meta: Internal This is an internal codebase change (testing, linting, etc.).
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Remove bootstrap
2 participants
@xPaw @richrd