Render styling for colored host masks #4235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: I updated every component I could find. |
angerson
changed the title
|
Thanks for the PR, @angerson! It seems like there's a small linting error in |
On some IRC networks, users have vanity host masks with colors or other text styling. Rizon is one such network. For example, a user connecting from 127.0.0.1 could instead have the host angerson@this.is.my.host.mask. this.is.my.host.mask may have IRC color code characters in it, which without this change would be displayed as a bunch of jumbled garbage in the /whois response or join/part messages. Resolves thelounge#4232.
|
Done, thanks @MaxLeiter. |
MaxLeiter
added
the
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some IRC networks, users have vanity host masks with colors or other text styling.
Rizon is one such network.
For example, a user connecting from
127.0.0.1could instead have the hostangerson@this.is.my.host.mask.this.is.my.host.maskmay have IRC color codecharacters in it, which without this change would be displayed as a bunch of jumbled
garbage in the
/whoisresponse or join/part messages.Resolves #4232.