Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: include pre-releases in compatibility lookup #4506

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

brunnre8
Copy link
Member

@brunnre8 brunnre8 commented Mar 7, 2022

Semver doesn't treat pre-release versions as upgrades, meaning >4.3.0 isn't satisfied
by 4.3.1-rc.1.
For the purpose of TL plugins however, we are only interested in the semantic version and
expect that rc's adhere to the compatibility promise.

Semver doesn't treat pre-release versions as upgrades, meaning >4.3.0 isn't satisfied
by 4.3.1-rc.1.
For the purpose of TL plugins however, we are only interested in the semantic version and
expect that rc's adhere to the compatibility promise.
@ghost
Copy link

ghost commented Mar 7, 2022

Closes #4504.

Copy link
Member

@itsjohncs itsjohncs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't do any testing myself but I looked through sermver's docs to make sure I understand what's happening here and everything seems fine.

@itsjohncs itsjohncs self-assigned this Mar 8, 2022
@itsjohncs itsjohncs added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Mar 8, 2022
@brunnre8 brunnre8 added the Status: release-after-next reviewed and ready to merge, postponed to release after next (feature freeze of current release) label Mar 9, 2022
@itsjohncs itsjohncs added this to the 4.3.2 milestone Mar 10, 2022
@MaxLeiter MaxLeiter removed the Status: release-after-next reviewed and ready to merge, postponed to release after next (feature freeze of current release) label Apr 12, 2022
@MaxLeiter MaxLeiter merged commit e4840b4 into master Apr 12, 2022
@MaxLeiter MaxLeiter deleted the bookworm/versionComp branch April 12, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants