Fix breaking layout when switching portrait/landscape modes #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
the
Type: Bug
|
LGTM |
|
@williamboman, even when you switch back and forth between portrait and landscape? Also recommend trying to reside browser on desktop. |
|
Looks fine by me 👍 Would have expected the missing table-row to break the table, but it apparently doesn't o.O Good find, this is awesome! |
|
👍 'd by @MaxLeiter on IRC and minor (reverts to the original behavior), so merging. |
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
…e-switch Fix breaking layout when switching portrait/landscape modes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-adds the table layout in CSS removed in 3cddbbc, #332.
The essential difference between #332 and this, in the end, is that
display: table-rowwas removed from#chat .msg. That difference is what makes the unread marker possible.I don't know by which sorcery this is possible, but it works. This requires testing though! I tried different scenario, window size and resize, ...
@williamboman, could you give a try at this PR since you originally mentioned that issue on the IRC channel?