Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unhandled message color in default and Crypto themes #653

Merged
merged 1 commit into from
Oct 7, 2016
Merged

Fix unhandled message color in default and Crypto themes #653

merged 1 commit into from
Oct 7, 2016

Conversation

MaxLeiter
Copy link
Member

Before After
before after

@astorije
Copy link
Member

This is inherited from here and I believe it's on purpose that unhandled numerics are being dimmed out.
But I'm actually curious, what made you feel this needed fixing?

@astorije astorije added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Sep 29, 2016
@astorije astorije self-assigned this Sep 29, 2016
@MaxLeiter
Copy link
Member Author

At first I was unable to see the numbers, then realized they were there, just incredibly dim. Felt sloppy/unintentional to me for them to be "kind of" visible.

@astorije
Copy link
Member

Right, but note that this is true for the default theme as well, which I think needs fixing too.
What do you say we instead:

@MaxLeiter
Copy link
Member Author

Done, @astorije. Both morning and zenburn already handle unhandled messages:

Morning and Zenburn

@xPaw
Copy link
Member

xPaw commented Sep 30, 2016

Could this be a muted color, not completely black? It's slightly confusing as it might seem like a normal nickname, maybe we need to add an icon before the numeric?

@astorije
Copy link
Member

astorije commented Oct 2, 2016

@MaxLeiter, could you make it #ddd like #chat .time?

@MaxLeiter
Copy link
Member Author

Done

@xPaw xPaw merged commit 94781c9 into thelounge:master Oct 7, 2016
@xPaw xPaw added this to the 2.1.0 milestone Oct 7, 2016
@xPaw xPaw self-assigned this Oct 7, 2016
@MaxLeiter MaxLeiter deleted the MaxLeiter/crypto-unhandled branch October 7, 2016 16:41
@astorije astorije changed the title Fix unhandled message color in Crypto theme Fix unhandled message color in default and Crypto themes Oct 17, 2016
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
…ndled

Fix unhandled message color in Crypto theme
@xPaw xPaw unassigned astorije and xPaw Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants