Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[The Space Contract] refund if price higher then current price? #15

Closed
zxygentoo opened this issue Feb 17, 2022 · 1 comment · Fixed by #27
Closed

[The Space Contract] refund if price higher then current price? #15

zxygentoo opened this issue Feb 17, 2022 · 1 comment · Fixed by #27

Comments

@zxygentoo
Copy link

currency.transferFrom(msg.sender, property.ownerOf(tokenId_), price_);

If price_ is higher than current price, shouldn't we refund sender the part above?

@zxygentoo zxygentoo changed the title [ The Space Contract ] refund if price higher then current price? [The Space Contract] refund if price higher then current price? Feb 17, 2022
@guoliu
Copy link
Contributor

guoliu commented Feb 23, 2022

Since the bid price needs to be higher than the asking price, price_ is always higher than the current price. I think we can automatically set the price to the bid price (TODO) instead of refunding the sender. So price increases with bids, making it more reflective of market competitiveness.

@guoliu guoliu linked a pull request Apr 5, 2022 that will close this issue
@guoliu guoliu closed this as completed in #27 Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants