fix: busuanzi counter display bug #1233

nature1995 · 2019-10-22T05:11:19Z

Do not show count in homepage when access it at the first time.

PR Checklist

The commit message follows our guidelines.
Tests for the changes was maked (for bug fixes / features).
- Muse | Mist have been tested.
- Pisces | Gemini have been tested.
Docs in NexT website have been added / updated (for features).

PR Type

What is the current behavior?

The busuanzi counter can display properly.

Issue resolved: Yes

What is the new behavior?

Screenshots with this changes: N/A
Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

Does this PR introduce a breaking change?

Yes.
No.

Do not show count in homepage when access it at the first time.

welcome · 2019-10-22T05:11:21Z

Thanks so much for opening your first PR here!

stevenjoezhang · 2019-10-22T05:15:34Z

Would you like to have a discussion with @Liam0205 ?
#1154
https://github.com/theme-next/hexo-theme-next/pull/1154/files

GitHub
Add container for busuanzi counter widget by Liam0205 · Pull Request #1154 · theme-next/hexo-theme-next
PR Checklist Please check if your PR fulfills the following requirements:
The commit message follows our guidelines.
Tests for the changes was maked (for bug fixes / features).

Muse | Mist ha...

CLAassistant · 2019-10-22T05:15:59Z

All committers have signed the CLA.

nature1995 · 2019-10-22T05:22:58Z

因为之前写的没check通过，我就从新pull了一下

Liam0205 · 2019-10-22T05:37:31Z

As mentioned in the original issue #1154 , setting display: none helps busuanzi hide itself when busuanzi asynchronous scripts are not executed, which prevents broken result.

This is not a bug, but a feature.

nature1995 · 2019-10-22T05:41:47Z

As mentioned in the original issue post, setting display: none helps busuanzi hide itself when busuanzi asynchronous scripts are not executed, which prevents broken result.

This is not a bug, but a feature.

I think it need to display at the first time to access, or you could add an option which can have a choice for the user.

Liam0205 · 2019-10-22T05:44:42Z

As mentioned in the original issue post, setting display: none helps busuanzi hide itself when busuanzi asynchronous scripts are not executed, which prevents broken result.
This is not a bug, but a feature.

I think it need to display at the first time to access, or you could add an option which can have a choice for the user.

I'm not quite understand.

As you could found in the documentation of busuanzi, setting display: none is a recommended practice. This prevents broken display when asynchronous scripts are not executed, and when these scripts are well executed, the display property of the container will be correctly set again, which results in correct display.

Again: this is not a bug, this is a feature.

nature1995 · 2019-10-22T06:00:11Z

As mentioned in the original issue post, setting display: none helps busuanzi hide itself when busuanzi asynchronous scripts are not executed, which prevents broken result.
This is not a bug, but a feature.

I think it need to display at the first time to access, or you could add an option which can have a choice for the user.

I'm not quite understand.

As you could found in the documentation of busuanzi, setting display: none is a recommended practice. This prevents broken display when asynchronous scripts are not executed, and when these scripts are well executed, the display property of the container will be correctly set again, which results in correct display.

Again: this is not a bug, this is a feature.

I just see the doc in busuanzi's site which show below.
4、在访问量数据未取回来之前，我不想让页面显示为诸如“本站总访问量次”，显得太low，怎么办？
只需要如下css，不蒜子执行完毕会自动将标签显示出来，其他以此类推：

<span id="busuanzi_container_site_pv" style='display:none'>
    本站总访问量<span id="busuanzi_value_site_pv"></span>次
</span>

Liam0205 · 2019-10-22T06:02:41Z

As mentioned in the original issue post, setting display: none helps busuanzi hide itself when busuanzi asynchronous scripts are not executed, which prevents broken result.
This is not a bug, but a feature.

I think it need to display at the first time to access, or you could add an option which can have a choice for the user.

I'm not quite understand.
As you could found in the documentation of busuanzi, setting display: none is a recommended practice. This prevents broken display when asynchronous scripts are not executed, and when these scripts are well executed, the display property of the container will be correctly set again, which results in correct display.
Again: this is not a bug, this is a feature.

I just see the doc in busuanzi's site which show below.
4、在访问量数据未取回来之前，我不想让页面显示为诸如“本站总访问量次”，显得太low，怎么办？
只需要如下css，不蒜子执行完毕会自动将标签显示出来，其他以此类推：

 本站总访问量次

doesn't this sustain my point of view?

nature1995 · 2019-10-22T13:02:06Z

As mentioned in the original issue post, setting display: none helps busuanzi hide itself when busuanzi asynchronous scripts are not executed, which prevents broken result.
This is not a bug, but a feature.

I think it need to display at the first time to access, or you could add an option which can have a choice for the user.

I'm not quite understand.
As you could found in the documentation of busuanzi, setting display: none is a recommended practice. This prevents broken display when asynchronous scripts are not executed, and when these scripts are well executed, the display property of the container will be correctly set again, which results in correct display.
Again: this is not a bug, this is a feature.

I just see the doc in busuanzi's site which show below.
4、在访问量数据未取回来之前，我不想让页面显示为诸如“本站总访问量次”，显得太low，怎么办？
只需要如下css，不蒜子执行完毕会自动将标签显示出来，其他以此类推：

 本站总访问量次

doesn't this sustain my point of view?

But it can't display after loading in the first time.

Liam0205 · 2019-10-23T00:12:58Z

Nonsense! After execution, the display property of the container will be modified to display: inline automatically.

Things works fine on my blog and on my test site. If you insist, provide a complete path for reproducing the problem.

nature1995 · 2019-10-23T23:43:00Z

It still not display in the first time. It is diplayed after refresh the site.

Liam0205 · 2019-10-24T02:33:21Z

It still not display in the first time. It is diplayed after refresh the site.

As requested before, provide a complete path for reproducing the problem.

pplmx · 2019-10-31T12:15:01Z

I found that if you both enabled live2d and busuanzi, which causes that busuanzi style="display: none".
If you disabled live2d, busuanzi would work well.

nature1995 · 2019-10-31T22:53:37Z

I found that if you both enabled live2d and busuanzi, which causes that busuanzi style="display: none".
If you disabled live2d, busuanzi would work well.

I think you are right. It the same situation as me.

stevenjoezhang · 2019-11-01T02:37:43Z

If you guys can solve the problem after disabling live2d, then it sounds like it's not a bug of busuanzi.

Liam0205 · 2019-11-01T02:40:27Z

That's why I asked for a complete path for reproducing the problem, since we have no idea about what you had done before you enabled busuanzi.

stevenjoezhang · 2019-11-22T02:04:24Z

I found that if you both enabled live2d and busuanzi, which causes that busuanzi style="display: none".
If you disabled live2d, busuanzi would work well.

I'm not sure which plugin you are using, but this has proven that this is not a bug in the theme NexT. Please ask the maintainer of the plugin for help.
I also have a live2d plugin that is compatible with busuanzi. If you are interested, you can check it out: https://github.com/stevenjoezhang/live2d-widget

GitHub
stevenjoezhang/live2d-widget
把萌萌哒的看板娘抱回家 | Live2D widget for web platform. Contribute to stevenjoezhang/live2d-widget development by creating an account on GitHub.

stevenjoezhang · 2020-02-13T06:40:52Z

正常情况下， busuanzi 会向 head 中 append 的一个 script 标签名为 scriptTag，用于加载数据；数据加载完成后，通过 scriptTag.parentElement.removeChild(scriptTag) 移除之；在启用 hexo-helper-live2d 时，scriptTag.parentElement 为 null （原因未知），导致 try catch 语句执行，通过 bszTag.hides() 将页面上的所有统计数据隐藏。我个人没有兴趣继续研究此问题，目前只能建议不要同时使用 busuanzi 和 hexo-helper-live2d。考虑到此问题与 NexT 主题本身无关，请联系这两个项目的维护者讨论和解决。

ouuan · 2022-08-05T14:06:22Z

关于 busuanzi 和 live2d 共同使用的问题，我找到了根本原因，写了篇博客: https://ouuan.moe/post/2022/08/busuanzi-and-live2d

fix: busuanzi bug

e0c51f4

Do not show count in homepage when access it at the first time.

auto-assign bot requested review from ivan-nginx, maple3142, sli1989 and stevenjoezhang October 22, 2019 05:11

nature1995 closed this Oct 22, 2019

stevenjoezhang mentioned this pull request Oct 22, 2019

Fix busuanzi bug #1234

Closed

15 tasks

stevenjoezhang reopened this Oct 22, 2019

This comment has been minimized.

Sign in to view

stevenjoezhang mentioned this pull request Nov 1, 2019

busuanzi计数显示不稳定 #1229

Closed

stevenjoezhang closed this Nov 22, 2019

stevenjoezhang mentioned this pull request Feb 24, 2020

不蒜子标识错位 iissnan/hexo-theme-next#1966

Closed

3 tasks

stevenjoezhang mentioned this pull request Mar 11, 2020

模型live2d-widget-model-haruto，与busuanzi2.3不兼容 EYHN/hexo-helper-live2d#146

Closed

2 tasks

stevenjoezhang mentioned this pull request Apr 7, 2020

【必读】更新说明及常见问题 next-theme/hexo-theme-next#4

Open

stevenjoezhang mentioned this pull request Nov 22, 2020

关于和不蒜子计数冲突的问题 EYHN/hexo-helper-live2d#161

Closed

2 tasks

stevenjoezhang mentioned this pull request Jan 5, 2021

add "vendors.busuanzi" to _config.yml setting next-theme/hexo-theme-next#173

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: busuanzi counter display bug #1233

fix: busuanzi counter display bug #1233

nature1995 commented Oct 22, 2019 •

edited

Loading

welcome bot commented Oct 22, 2019

stevenjoezhang commented Oct 22, 2019 •

edited by unfurl-links bot

Loading

CLAassistant commented Oct 22, 2019 •

edited

Loading

nature1995 commented Oct 22, 2019

This comment has been minimized.

Liam0205 commented Oct 22, 2019 •

edited

Loading

nature1995 commented Oct 22, 2019

Liam0205 commented Oct 22, 2019

nature1995 commented Oct 22, 2019

Liam0205 commented Oct 22, 2019

nature1995 commented Oct 22, 2019

Liam0205 commented Oct 23, 2019

nature1995 commented Oct 23, 2019

Liam0205 commented Oct 24, 2019

pplmx commented Oct 31, 2019

nature1995 commented Oct 31, 2019

stevenjoezhang commented Nov 1, 2019

Liam0205 commented Nov 1, 2019

stevenjoezhang commented Nov 22, 2019 •

edited by unfurl-links bot

Loading

stevenjoezhang commented Feb 13, 2020 •

edited

Loading

ouuan commented Aug 5, 2022 •

edited

Loading

fix: busuanzi counter display bug #1233

fix: busuanzi counter display bug #1233

Conversation

nature1995 commented Oct 22, 2019 • edited Loading

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

How to use?

Does this PR introduce a breaking change?

welcome bot commented Oct 22, 2019

stevenjoezhang commented Oct 22, 2019 • edited by unfurl-links bot Loading

CLAassistant commented Oct 22, 2019 • edited Loading

nature1995 commented Oct 22, 2019

This comment has been minimized.

Liam0205 commented Oct 22, 2019 • edited Loading

nature1995 commented Oct 22, 2019

Liam0205 commented Oct 22, 2019

nature1995 commented Oct 22, 2019

Liam0205 commented Oct 22, 2019

nature1995 commented Oct 22, 2019

Liam0205 commented Oct 23, 2019

nature1995 commented Oct 23, 2019

Liam0205 commented Oct 24, 2019

pplmx commented Oct 31, 2019

nature1995 commented Oct 31, 2019

stevenjoezhang commented Nov 1, 2019

Liam0205 commented Nov 1, 2019

stevenjoezhang commented Nov 22, 2019 • edited by unfurl-links bot Loading

stevenjoezhang commented Feb 13, 2020 • edited Loading

ouuan commented Aug 5, 2022 • edited Loading

nature1995 commented Oct 22, 2019 •

edited

Loading

stevenjoezhang commented Oct 22, 2019 •

edited by unfurl-links bot

Loading

CLAassistant commented Oct 22, 2019 •

edited

Loading

Liam0205 commented Oct 22, 2019 •

edited

Loading

stevenjoezhang commented Nov 22, 2019 •

edited by unfurl-links bot

Loading

stevenjoezhang commented Feb 13, 2020 •

edited

Loading

ouuan commented Aug 5, 2022 •

edited

Loading