New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add refer for livere #395

Merged
merged 1 commit into from Sep 2, 2018

Conversation

Projects
None yet
3 participants
@KaitoHH
Copy link
Contributor

KaitoHH commented Aug 23, 2018

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

When you use LiveRe comment box, LiveRe uses full URL as its identifier by default. Consider these 2 URLs:

example.com/my_article/
example.com/my_article/index.html

These two URLs actually access to the same page, but LiveRe will treat them differently, so you won't see same comments on these two URLs.

What is the new behavior?

I added refer to be equal to page.path according to the official documentation. Since this way is also be used in disqus when defining identifier:

this.page.identifier = '{{ page.path }}';

I believe it can fix this bug.

Does this PR introduce a breaking change?

  • Yes.
  • No.

@sli1989 sli1989 added the Bugfix label Aug 23, 2018

@sli1989 sli1989 added this to the v6.5.0 milestone Aug 23, 2018

@sli1989 sli1989 merged commit cc3ebfc into theme-next:master Sep 2, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sli1989 sli1989 modified the milestones: v6.4.1, v6.5.0 Sep 2, 2018

Jona-lee added a commit to Jona-lee/hexo-theme-next that referenced this pull request Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment