Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid HTML on the sidebar #242

Open
MikeAlhayek opened this issue May 8, 2019 · 2 comments
Open

Invalid HTML on the sidebar #242

MikeAlhayek opened this issue May 8, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@MikeAlhayek
Copy link

First of all I want to thank you for this great template!

The menu code looks like the following

<ul class="collapse show" id="dashboard" data-parent="#sidebar-menu">
   <div class="sub-menu">
      <li class="active">
         <a class="sidenav-item-link" href="index.html">
         <span class="nav-text">Ecommerce</span>
         </a>
      </li>
      <li>
         <a class="sidenav-item-link" href="analytics.html">
         <span class="nav-text">Analytics</span>
         <span class="badge badge-success">new</span>
         </a>
      </li>
   </div>
</ul>

However, it is invalid to add <div> between the <ul> and the <li>

I recommend that you change the code so something like this

<ul class="collapse show sub-menu" id="dashboard" data-parent="#sidebar-menu">
      <li class="active">
         <a class="sidenav-item-link" href="index.html">
         <span class="nav-text">Ecommerce</span>
         </a>
      </li>
      <li>
         <a class="sidenav-item-link" href="analytics.html">
         <span class="nav-text">Analytics</span>
         <span class="badge badge-success">new</span>
         </a>
      </li>
</ul>

Of course, the CSS code may have to change as well to accommodate the change

@sama55
Copy link

sama55 commented Nov 8, 2019

I also detected the same problem.

@faruqtaf
Copy link
Contributor

Thanks for letting us know about the issue. We will fix it soon.

@iamabdus iamabdus added the bug Something isn't working label Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants