-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues unzipping demo-content when wordpress root is on NFS #50
Comments
Hey @cu12, Have you tried to swap out the implementation for |
hey @andreiglingeanu Indeed, dumbly modifying the function like this, makes this working
it's a good idea to use the canonical function anyway. |
That's true, but I'm not entirely sure why that method was implemented that way in the first place. I'll have to look it up before swaping out the implementation. |
This function return path to folder fw-backup/tmp dir created in folder uploads this is not the same as default get_temp_dir() directly in tmp this is added and for another reasons it can be rewritten from config.php param dirs.destination, some plugins are badly programmed by deleting all of that folder it results that it will delete and your backup( plugins what works with downloaded files cache etc but not only plugins touch this folder). |
@ViorelEremia thanks for working on this, the function returns something like the following:
Now the problem is not the path, but the filesystem behind it which is Gluster used via NFS. After the download finishes, it's not guaranteed that it's already been fsync'd to the filesystem, therefore an immediate read could end up in a "bad" zip file. Making the download defaulting in |
I do not think I have to focus on this issue, and I do not know how to do this so as not to affect the others so if you find a solution create a pull request. |
I was testing an issue with a theme that uses your framework, where installing demo content was constantly failing.
After some investigation it turned out that it's most probably due to the reason we're using NFS as Wordpress root. It appears to be that due to
async
mounted NFS drive the OS reports the file has been sync'd, but in reality it hasn't been written on NFS yet.My presumtion that this function could rather use sys_get_temp_dir in order to make it fail-proof.
The text was updated successfully, but these errors were encountered: