Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): Add displayNames for syntax highlighter, resolving #70 #73

Merged

Conversation

tulup-conner
Copy link
Collaborator

Adds displayName fields to compound components.

This is essential for the syntax highlighter we use to display the code needed for each component.

For example, <ButtonComponent>, which is invalid, now becomes <Button>, which is ready to copy-paste.

…hemesberg#70

Adds `displayName` fields to compound components.
This is essential for the syntax highlighter we
use to display the code needed for each component.

For example, `<ButtonComponent>`, which is invalid,
now becomes `<Button>`, which is ready to copy-paste.
@tulup-conner tulup-conner force-pushed the fix/syntax-highlighter-displaynames branch from b236271 to 0f83f93 Compare May 1, 2022 00:22
@tulup-conner
Copy link
Collaborator Author

@rluders In reference to your Discord messages, let me where I should keep the displayName assignments. I'd be happy to update the other components, or change mine to conform to the existing style

@rluders rluders merged commit 6741a83 into themesberg:main May 2, 2022
@tulup-conner tulup-conner deleted the fix/syntax-highlighter-displaynames branch May 2, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants