Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Update README Components links to new URL pattern #84

Merged
merged 2 commits into from
May 5, 2022

Conversation

tulup-conner
Copy link
Collaborator

We don't use HashRouter anymore, so the links no longer begin with #. Also adds anchors to the Forms page for each of the components listed (radio, checkbox, and so forth).

Breaking changes

None.

Features

None.

Bug fixes

  • Update README Components links to new URL pattern

We don't use `HashRouter` anymore, so the links no
longer begin with `#`. Also adds anchors to the
`Forms` page for each of the components listed
(radio, checkbox, and so forth).
@tulup-conner tulup-conner marked this pull request as ready for review May 5, 2022 01:29
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tulup-conner
Copy link
Collaborator Author

tulup-conner commented May 5, 2022

@bacali95

Thank you! I made those changes and also:

  • Changed Sidebar to not be under construction
  • Reverted some other links that were broken (Typography, components that are not yet converted to flowbite-react yet)

@bacali95 bacali95 self-requested a review May 5, 2022 06:33
@bacali95
Copy link
Collaborator

bacali95 commented May 5, 2022

@bacali95

Thank you! I made those changes and also:

  • Changed Sidebar to not be under construction
  • Reverted some other links that were broken (Typography, components that are not yet converted to flowbite-react yet)

Great thanks, let's merge this one

@bacali95 bacali95 merged commit 39c2d91 into themesberg:main May 5, 2022
@tulup-conner tulup-conner deleted the fix/readme-component-links branch May 5, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants