Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include new JMdict dictionaries in README #124

Closed
Aquafina-water-bottle opened this issue Apr 5, 2023 · 0 comments · Fixed by #305
Closed

Include new JMdict dictionaries in README #124

Aquafina-water-bottle opened this issue Apr 5, 2023 · 0 comments · Fixed by #305
Labels
area/documentation The issue or PR is about documentation triage/accepted The issue or PR is ready to be actively worked on

Comments

@Aquafina-water-bottle
Copy link

The new dictionaries from @stephenmk would be nice to officially have in the README of the repo. However, we should provide the unstylized / old versions as well, due to importing taking forever:

Since my new version takes ~30 minutes or so to validate during the import process, it might not be wise to publish it for the general public until a solution is worked out. 1

In the most ideal scenario, it would be nice to have these dictionaries auto-updated every week or so, maybe through some sort of Github actions.

An alternative to linking the new dictionaries in the README is to link to some other repository that houses the dictionary files, to better separate concerns between the repositories.

Footnotes

  1. https://github.com/FooSoft/yomichan-import/pull/40#issuecomment-1407529901

@Aquafina-water-bottle Aquafina-water-bottle added the area/documentation The issue or PR is about documentation label Apr 5, 2023
@djahandarie djahandarie added the triage/accepted The issue or PR is ready to be actively worked on label Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation The issue or PR is about documentation triage/accepted The issue or PR is ready to be actively worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants