Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't search within popup anymore. #317

Closed
wwly23 opened this issue Nov 12, 2023 · 5 comments
Closed

Can't search within popup anymore. #317

wwly23 opened this issue Nov 12, 2023 · 5 comments
Labels
kind/bug The issue or PR is regarding a bug

Comments

@wwly23
Copy link

wwly23 commented Nov 12, 2023

Description
Used to work, but now it doesn't. Can't look up words within a J-J definition anymore for example. I can still do it on Chrome with Yomichan. Not sure what changed. Settings are the same. Allow scanning popup content checked. Maximum number of child popups: 5.

Browser version
Firefox 119.0.1 (64-bit)
Yomitan version
23.11.10.0 (the version I had before this one has the same issue)

Exported settings file
(If you think it might be relevant, create a settings export file using the Export Settings button on the settings page; zip or rename the resulting file to .txt to attach to the issue.)

@wwly23 wwly23 added the kind/bug The issue or PR is regarding a bug label Nov 12, 2023
@jbukl
Copy link

jbukl commented Nov 12, 2023

Tested a bit and it looks like it was inadvertently resolved by #315 - just isn't in the release version yet

@djahandarie
Copy link
Collaborator

I'll release a new version later today with the fix!

@praschke
Copy link
Collaborator

sorry, my test install didn't have scanning in the popup enabled. this problem does seem to be resolved.

@djahandarie
Copy link
Collaborator

@wwly23 Just released the new version, please confirm it's fixed for you once updated!

@wwly23
Copy link
Author

wwly23 commented Nov 12, 2023

Perfect! Works great now, thanks guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

No branches or pull requests

4 participants