forked from FooSoft/yomichan
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't search within popup anymore. #317
Labels
kind/bug
The issue or PR is regarding a bug
Comments
Tested a bit and it looks like it was inadvertently resolved by #315 - just isn't in the release version yet |
I'll release a new version later today with the fix! |
sorry, my test install didn't have scanning in the popup enabled. this problem does seem to be resolved. |
@wwly23 Just released the new version, please confirm it's fixed for you once updated! |
Perfect! Works great now, thanks guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Used to work, but now it doesn't. Can't look up words within a J-J definition anymore for example. I can still do it on Chrome with Yomichan. Not sure what changed. Settings are the same. Allow scanning popup content checked. Maximum number of child popups: 5.
Browser version
Firefox 119.0.1 (64-bit)
Yomitan version
23.11.10.0 (the version I had before this one has the same issue)
Exported settings file
(If you think it might be relevant, create a settings export file using the Export Settings button on the settings page; zip or rename the resulting file to .txt to attach to the issue.)
The text was updated successfully, but these errors were encountered: