Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Google Docs URL regex to not be excessively wide #107

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Fix Google Docs URL regex to not be excessively wide #107

merged 1 commit into from
Mar 25, 2023

Conversation

djahandarie
Copy link
Collaborator

As reported by CodeQL:

This string, which is used as a regular expression , has an unescaped '.' before 'google.com/', so it might match more hosts than expected.

@djahandarie djahandarie added the kind/bug The issue or PR is regarding a bug label Mar 25, 2023
@github-actions
Copy link

github-actions bot commented Mar 25, 2023 •
edited
Loading

✔️ No visual differences introduced by this PR.
View Playwright Report (note: open the "playwright-report" artifact)

@djahandarie djahandarie merged commit 346c7c5 into master Mar 25, 2023
@djahandarie djahandarie deleted the fix-google-docs-regex branch March 25, 2023 03:27
Casheeew pushed a commit to Casheeew/lesen-tan that referenced this pull request Jul 20, 2024
@StefanVukovic99
use translations section to create more dictionaries (yomidevs#107)
cc8d9e3 
* rename to main.sh

* groundwork

* mvp

* delete comments

* exit if no translations

* wip

* move to function

* mvp

* use sense as subheading

* glossary only flag

* formatting

* no monolingual translations

* indent

* revert script name to auto.sh

* revert script name to auto.sh

* fixes

* try to use less space

* try matrix

* try matrix

* try matrix

* fix quote

* uncomment release

* vert

* echo

* try softprops again

* try fixing merge ipa and speed up conversion

* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rudo2204 Rudo2204 Rudo2204 approved these changes

Assignees
No one assigned
Labels
kind/bug The issue or PR is regarding a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djahandarie @Rudo2204