Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move check integrity button to advanced #1177

Merged

Conversation

StefanVukovic99
Copy link
Collaborator

I'm not sure what this even does, but it takes up some space and I want to add a 'Check for updates' button there in #1174

@StefanVukovic99 StefanVukovic99 added the area/ui-ux The issue or PR is related to UI/UX/Design label Jul 6, 2024
@StefanVukovic99 StefanVukovic99 requested a review from a team as a code owner July 6, 2024 14:23
@Kuuuube
Copy link
Member

Kuuuube commented Jul 6, 2024

It does what it says it does. Same thing that happens when dicts are imported and checked. Though I've never seen anyone with a broken dictionary in their database and it certainly isn't something we need to have visible normally.

Possibly a holdover from a time where Yomitan database writes were less reliable? Not sure.

@StefanVukovic99 StefanVukovic99 added this pull request to the merge queue Jul 6, 2024
Merged via the queue into yomidevs:master with commit 9c46fd4 Jul 6, 2024
10 of 11 checks passed
@StefanVukovic99 StefanVukovic99 deleted the check-integrity-advanced branch July 6, 2024 14:37
@Kuuuube Kuuuube added the kind/enhancement The issue or PR is a new feature or request label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants