Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove web-ext dev dependency #263

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Remove web-ext dev dependency #263

merged 1 commit into from
Oct 1, 2023

Conversation

djahandarie
Copy link
Collaborator

Why

The web-ext dependency is:

  1. massive and pulls in tons of other code (as can be seen from this +191 -6,735 lock-file diff...)
  2. has a couple security vulnerabilities that have been open for months
  3. is only used for linting the manifest

What

Remove the web-ext dev dependency, since we already lint the manifest in CI with a purpose-built action anyways

@djahandarie djahandarie requested a review from a team as a code owner October 1, 2023 06:32
@djahandarie djahandarie added this pull request to the merge queue Oct 1, 2023
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

Merged via the queue into master with commit 8d7caab Oct 1, 2023
6 checks passed
@djahandarie djahandarie deleted the remove-web-ext branch October 1, 2023 06:37
@djahandarie djahandarie mentioned this pull request Oct 1, 2023
Merged
@djahandarie djahandarie added the area/dependencies The issue or PR is related to dependencies label Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themoeway-bot themoeway-bot themoeway-bot approved these changes

Assignees
No one assigned
Labels
area/dependencies The issue or PR is related to dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djahandarie @themoeway-bot