Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of AbstractWinkModel? #91

Closed
idragon81 opened this issue Dec 4, 2018 · 1 comment
Closed

Use of AbstractWinkModel? #91

idragon81 opened this issue Dec 4, 2018 · 1 comment

Comments

@idragon81
Copy link

Any reason why we are extending all of the models with AbstractWinkModel?

From what I can see the only real use they are providing is overriding the DB Connection for Wink.

We can Reduce the WinkAuthor code by half by extending from Illuminate\Foundation\Auth\User, using AbstractWinkModel as a trait and removing all the redundant code.

I think this will help us keep the WinkAuthor model close to Laravel defaults

@themsaid
Copy link
Owner

Thanks for the suggestion, I'm doing some work in this area and will see if that still makes sense after I'm done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants