Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pylint exception to 'from horton import *' in tests #19

Closed
tovrstra opened this issue May 24, 2016 · 2 comments
Closed

Add pylint exception to 'from horton import *' in tests #19

tovrstra opened this issue May 24, 2016 · 2 comments
Assignees
@tovrstra
Labels
QA
Milestone
2.2.0

Comments

@tovrstra
Copy link
Member

This is the proper way to import horton in tests because it mimics the typical usage pattern. To keep pylint happy, we should do it as follows:

from horton import *  # pylint: disable=wildcard-import,unused-wildcard-import
@tovrstra tovrstra added this to the 2.0.1 milestone May 25, 2016
@tovrstra tovrstra self-assigned this May 25, 2016
@matt-chan matt-chan added the QA label May 28, 2016
@tovrstra tovrstra modified the milestones: 2.2.0, 2.0.1 Jun 1, 2016
@tovrstra
Copy link
Member Author

tovrstra commented Jun 1, 2016

I'm moving this to 2.2.0 because this is a change that touches every test file. That makes merging of existing branches harder, which we'd like to do in 2.1.0.

@tovrstra
Copy link
Member Author

tovrstra commented Jun 4, 2016

This was fixed in #67.

@tovrstra tovrstra closed this as completed Jun 4, 2016
tovrstra pushed a commit that referenced this issue Sep 12, 2016
Merge pull request #19 from tovrstra/buildkiteQA
0273aa7 
Fix random test problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tovrstra tovrstra

Labels
QA
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
2 participants
@tovrstra @matt-chan