Fix asymptotics of Poisson solver for small r (final) #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's failing because of the wildcard imports in the test files. I thought we had suppressed them? |
|
I had only fixed them where we had errors. This PR seems to cause trouble with all of them. I'll fix. |
tovrstra
force-pushed
the
fix_hartree_splines
branch
from
d2d581e
to
f8f1caf
Compare
|
I've rebased to fix merge conflicts. |
|
I'm going to rebase this again to resolve merge conflicts. Hang on for a sec... |
Also a few fixes are included to avoid division by zero in IntGrid.eval_decomposition. This commit includes tests for the fixed bugs.
- Improved output - Tuned settings
Most fixes are trivial except for one. Cpplint suggests to use int64_t instead of long, which is a good idea. However, that implies that we compile our C++ code with -std=c++11. That all works fine but it is a non-trivial change.
Parsing of the warnings log was not always working.
This is needed for C++11 support and it is not a bad idea to use a more recent compiler anyway.
This is the first release with complete C++11 support. (In principle, 4.8.1 was meant to be that but it was apparently still missing regex.)
tovrstra
force-pushed
the
fix_hartree_splines
branch
from
f8f1caf
to
76acd46
Compare
|
Looks good! On another note, I should really figure out a better way to review large PRs. It's too easy to start to skim when looking at something big. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first bug fix that involves changes in the C++ code and I ran into a lot of small issues with the C++ trapdoor scripts, which are also fixed in the commits below.
Summary:
cubic_spline.*(I could have done just the new ones but I wanted to do more for the sake of testing the trapdoor scripts.)int64_tinstead oflong(just in one place). That is indeed clearer but requires us to switch to c++11, which just worked fine on my computer.doxygen_warnings.logcubuc_spline.h(Again, I could have done just part of the file but I wanted to do all of it to test the trapdoor_doxygen.py script.)The more-than-necessary changes in
cubic_spline.*should not interfere with branches to be merged in 2.1.0.