Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pressure switch/sensor types #223

Closed
blip2 opened this issue Mar 14, 2024 · 5 comments
Closed

pressure switch/sensor types #223

blip2 opened this issue Mar 14, 2024 · 5 comments

Comments

@blip2
Copy link
Contributor

blip2 commented Mar 14, 2024

I've had a request for the following additions from within one of our design teams:
TDSW – switch - thermal dispersion flow proving switch
DPX – sensor – differential pressure sensor
LPS – switch – low pressure switch
HPS – switch – high pressure switch

couple of points for discussion here:

  • do we want to differentiate between a pressure sensor and switch. I would argue yes, physically and logically these are different things, former provides an analogue value, latter is boolean
  • do we want to differentiate between low/high pressure. I would argue no, they are physically the same thing (except maybe N/C or N/O arrangement)
  • thermal dispersion flow proving switch is probably a fair addition though quite specific - any thoughts?
@blip2
Copy link
Contributor Author

blip2 commented Mar 15, 2024

also:
SPSW - Static Pressure Switch

@RitaLav
Copy link
Collaborator

RitaLav commented Mar 20, 2024

Generally we do have both sensors and switches on bdns.

Some suggestions:

For differential pressure sensor maybe follow the abbreviation logic of the differential pressure switch (eg we can call the sensor DPRS)

TDSW - should be ok if needed/useful for project teams

SPSW - ok

bdns

Could you do a pull request for DPRS, SPSW and TDSW?

@pisuke @jgunstone any thoughts on high/low pressure switch discussion point raised (generic vs low/high pressure switch)?

blip2 added a commit to blip2/BDNS that referenced this issue Mar 20, 2024
@RitaLav
Copy link
Collaborator

RitaLav commented Mar 27, 2024

on the last point, it was discussed today. Please add a generic pressure switch - PSW or PRSW (rather than adding low and high)

@RitaLav
Copy link
Collaborator

RitaLav commented Apr 10, 2024

Will add:
sensor - differential pressure sensor,DPS,SENSOR,IfcSensor,PRESSURESENSOR
switch - differential pressure,DPSW,,IfcSwitchingDevice,NOTDEFINED
switch - absolute pressure,APSW, ,IfcSwitchingDevice,NOTDEFINED
switch - static pressure,SPSW, ,IfcSwitchingDevice,NOTDEFINED
switch - thermal dispersion flow proving switch,TDSW, ,IfcSwitchingDevice,NOTDEFINED

We will also need to amend the existing dew point switch abbreviation from 'DPSW' to 'DEWSW' and modify its ifc class to IfcSwitchingDevice

blip2 added a commit to blip2/BDNS that referenced this issue Apr 10, 2024
rename DPRS to pressure sensor

added PRSW pressure switch

refactored to include switches correctly
blip2 added a commit to blip2/BDNS that referenced this issue Apr 10, 2024
DPSW (previosuly dew point switch) is now DEWSW
@RitaLav
Copy link
Collaborator

RitaLav commented Apr 17, 2024

Pull request #224 merged.

@RitaLav RitaLav closed this as completed Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants