-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pressure switch/sensor types #223
Comments
also: |
Generally we do have both sensors and switches on bdns. Some suggestions: For differential pressure sensor maybe follow the abbreviation logic of the differential pressure switch (eg we can call the sensor DPRS) TDSW - should be ok if needed/useful for project teams SPSW - ok Could you do a pull request for DPRS, SPSW and TDSW? @pisuke @jgunstone any thoughts on high/low pressure switch discussion point raised (generic vs low/high pressure switch)? |
on the last point, it was discussed today. Please add a generic pressure switch - PSW or PRSW (rather than adding low and high) |
Will add: We will also need to amend the existing dew point switch abbreviation from 'DPSW' to 'DEWSW' and modify its ifc class to IfcSwitchingDevice |
rename DPRS to pressure sensor added PRSW pressure switch refactored to include switches correctly
DPSW (previosuly dew point switch) is now DEWSW
Pull request #224 merged. |
I've had a request for the following additions from within one of our design teams:
TDSW – switch - thermal dispersion flow proving switch
DPX – sensor – differential pressure sensor
LPS – switch – low pressure switch
HPS – switch – high pressure switch
couple of points for discussion here:
The text was updated successfully, but these errors were encountered: