-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby: Installing Ruby: Update to latest patch version #28403
Comments
I don't remember what my intention was with that Project Management bit and whether 3.2.2 was chosen because that's what I was used to running when going through the curriculum or just the first version that came into my head. It's supposed to be an example, a version you could declare, not the one you necessarily have to declare. It actually makes sense that your local version would differ from the globally used one. Since the problem on Discord was not connecting the fact that declaring a version requires you to have that version installed, I'd probably tackle it from another angle - perhaps by elaborating:
This would save on the necessity of changing Ruby version when curriculum changes the one it expects and perhaps make it clear that it does not matter what version is declared. |
Possibly related - would it be worth updating theodinproject's repo wiki to be version agnostic as well for what it currently has as |
Why not put the downloads page for ruby in the lesson and have students checkout what the latest version is before running the commands in the lesson? The version number is always changing so we can just say I would like to work on this issue! |
I think this idea is probably better than what I wrote above, but I also think it'd be nice to just give learners the command to list out their So maybe have it be something like:
Does that seem okay? @scheals |
@MaoShizhong Yeah we can definitely do something with that. I'd probably advocate changing this to tell users to run the command with the version named in the
This is another good idea @dellaighted. I probably slightly prefer what I have above with Scheals about listing out versions and using one. Teaches people that they can set the local to any of their installed versions and conveys more useful information about rbenv, while also being flexible and future-proofed against future version changes. As soon as I get the go-ahead on what I wrote above from scheals, I'll assign this to you. Thank you for volunteering! |
@JoshDevHub awesome, I'll leave that bit with you then since you know better about me on that. |
@JoshDevHub |
Awesome! I'll assign you @dellaighted . Adjusted the acceptance criteria to the new plan on the Project Management lesson. Let me know if you have any questions 👍 |
Just to be clear @JoshDevHub am I also doing the first part of the acceptance criteria (i.e. the Installing Ruby lesson)? Should I change the |
In the Installing Ruby lesson, change all references to the Ruby version to |
Problem
The Ruby install lesson tells learners to install
3.3.0
. The newest patch version for Ruby with the latest security fixes is3.3.4
. Learners should install the latest available version.Additionally in "Project Management" lesson, learners are told to run the command
rbenv local 3.2.2
to declare the ruby version local to a project. This needs to be adjusted so it's not as dependent on the current Ruby version the curriculum is usingAcceptance Criteria
3.3.0
to3.3.4
.Comment below to be assigned 🚀
The text was updated successfully, but these errors were encountered: