Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]Could not parse the price with floating number #29

Closed
Tollainmear opened this issue Mar 21, 2018 · 3 comments
Closed

[BUG]Could not parse the price with floating number #29

Tollainmear opened this issue Mar 21, 2018 · 3 comments

Comments

@Tollainmear
Copy link

If set a sign which assigned a number with floating number at 4th line, the shop will with wrong price setup.

qq 20180321134921

using the latest version of Carrotshop in Spongeapi7.

Tollainmear added a commit to Tollainmear/CarrotShop that referenced this issue May 17, 2018
@TheoKah
Copy link
Owner

TheoKah commented May 26, 2018

Hi,

I'll see what can be done.
Note that I cannot accept your PR as it is because it changes the color of the sign even when no shop is actually created.

@Tollainmear
Copy link
Author

fine, it's dosen't matter, I have noticed that you are using the integer variable to store the price, so to solve it, I tried to change those variables to float

@TheoKah
Copy link
Owner

TheoKah commented Sep 8, 2018

Hi. I added support for floating numbers. This will be available in the next release later today or tomorrow

@TheoKah TheoKah closed this as completed Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants