-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug with GP] On player sold blocks #30
Comments
Has this problem been reported to GP? Only allowing use of signs with empty hand is not acceptable. I would gladly lower the Listener from "AFTER_PRE" to "FIRST" and cancel the event. But this might cause problem with people not being able to use the signs in claimed areas. |
so just check if the player's hand was not empty. |
I do not want to restrict shop use to empty hand. Have you reported this to GP? I'm happy changing a few things if needed, as long as it doesn't change the gameplay I'll close in this issue in the meantime. |
Actually I'm adding a config option to enforce empty hand when using signs. (default to false) Will be in next release later today or tomorrow |
as we know, GriefPrevention has a protection to prevent strangers build block in a personal claim, that appears if a stranger place a block, GP cancel it and return the block to him.
The bug is if the customer doesn't have claims permission to place blocks when he sell block with shifting mode(sneak), the sold block action (right interact the sign) would be regard as place event by GP, so GP prevent placing event and give block back to the customer while doesn't cancel the sell event. so customer will earn money by none block paid.
The text was updated successfully, but these errors were encountered: