Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsecured Dev Endpoints #923

Closed
jkhsjdhjs opened this issue Mar 15, 2024 · 2 comments
Closed

Unsecured Dev Endpoints #923

jkhsjdhjs opened this issue Mar 15, 2024 · 2 comments
Labels

Comments

@jkhsjdhjs
Copy link
Contributor

Some development endpoints don't require ROLE_ADMIN and may be accessed by anyone:

  • /dev/crash may be used to crash any publicly accessible nzbhydra2 instance,
  • /dev/testAddToSonarr is probably less problematic, but it still shouldn't be accessible without login.

https://github.com/theotherp/nzbhydra2/blob/master/core/src/main/java/org/nzbhydra/DevEndpoint.java

I wrote a mail regarding this issue at first, as it has some abuse potential. However, I didn't receive a reply in 2 weeks, which is why I'm creating this issue now.

@jkhsjdhjs jkhsjdhjs added the bug label Mar 15, 2024
@theotherp
Copy link
Owner

theotherp commented Mar 15, 2024 via email

@theotherp
Copy link
Owner

Thanks for the report, I've added required admin access and additionally made the crash endpoint require a certain system property to be set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants