Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkce no longer appears in src/Provider/AbstractProvider.php #982

Closed
drennvinn opened this issue Nov 24, 2022 · 4 comments
Closed

pkce no longer appears in src/Provider/AbstractProvider.php #982

drennvinn opened this issue Nov 24, 2022 · 4 comments

Comments

@drennvinn
Copy link

Hello, I installed the project via composer (2.6.1) and started using it as described here but found out that AbstractProvider.php no longer had support for PKCE when I wanted to use

$provider = new \League\OAuth2\Client\Provider\GenericProvider([
    // ...
    // other options
    // ...
    'pkceMethod' => \League\OAuth2\Client\Provider\GenericProvider::PKCE_METHOD_S256
]);

So when i navigate to https://github.com/thephpleague/oauth2-client/blob/master/src/Provider/AbstractProvider.php i can found setPkceCode(), getPkceCode(), etc... but not in the sources after composer install

@megaxorg
Copy link

megaxorg commented Nov 28, 2022

Composer installs v2.6.1 from December 2021. PKCE support was added on Sep 12, 2022.

#901

@rhertogh
Copy link
Contributor

@drennvinn As @megaxorg mentioned the latest changes aren't released yet.
In the meantime you can use this workaround.

@carlituxman
Copy link

Trying the PR 43c59dd it works.

@ramsey
Copy link
Contributor

ramsey commented Apr 16, 2023

PKCE support is now available in version 2.7.0.

@ramsey ramsey closed this as completed Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants