update idpexception to account for empty strings #203
Conversation
Added support for Github Enterprise
Added Naver as Third-Party Provider
update google scopes and endpoint to remove deprecated values
New protected method is responsible for making the request to a provided URL, allowing for multiple API endpoints to be used within the same provider. AbstractProvider::fetchUserDetails() remains, but now only builds the user details URL and passes it to AbstractProvider::fetchProviderData().
Adds methods to allow fetching user email addresses from Github
Updated README.md to include Google Nest provider
User id being set for Google API
Fix UserTest.php namespace
Some providers (ex. Google) specify an error response object which is an empty string in cases where a 403/401 are returned. This will force the exception to check that the value isset and it is not an empty string which will help prevent the Unknown error case from occurring.
|
@geofflancaster Can you provide a test for this edge case? Thanks! |
|
Ping, @geofflancaster |
|
I'm here. Just swamped. I'll try to get to it tonight. Thanks, On Tue, Feb 10, 2015 at 11:37 AM, Ben Ramsey notifications@github.com
|
|
@geofflancaster, I'm ready to merge this in. I'd just like a test for it, please. :-) |
Added test cases for the empty string edge cases
|
Test cases added. |
|
Looks like there might be conflicts. Can you merge master into your branch and see what breaks, please? :-) |
This reverts commit ff344b2.
Closes #197 Ref: #197 (comment)
Added Twitch to the additional providers, and alphabetized the list for more grokkability.
This will be moved to its own package
Problem: Some providers are sending additional information when an error occurs, which can't be accessed because property `$result` is protected. Solution: Data from this property can be accessed using `getResponseBody()` method. Closes #185
As per recent Travis builds: > You are using the deprecated option "dev". Dev packages are installed by default now.
Conflicts: README.md composer.json src/Provider/Github.php test/src/Provider/GithubTest.php
|
merge complete. On Tue, Mar 10, 2015 at 3:25 PM, Ben Ramsey notifications@github.com
|
|
Thanks, @geofflancaster. That merge looked quite a bit hairy, and I'm not sure why the files listed as being in conflict were in conflict (for example, the README), since you didn't touch them in your branch. So, I pulled down your branch, backed out the merge, and then merged just your changes, resolving the conflict in IDPExceptionTest. As a result, the following new commits were created in thephpleague/oauth2-client master branch: Thanks! |
|
Agree. I thought that was strange too. Thanks for taking care of it. On Tue, Mar 10, 2015 at 4:10 PM, Ben Ramsey notifications@github.com
|
Some providers (ex. Google) specify an error response object which is an empty string in cases where a 403/401 are returned. This will force the exception to check that the value isset and it is not an empty string which will help prevent the Unknown error case from occurring.