Add conditionals for optional fields to PxPay request #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied the existing code for the 3 TxnData fields from PxPayAuthorizeRequest.php and added to PxPostAuthorizeRequest.php.
MerchantReference, TxnId, TxnData1, TxnData2, and TxnData3 are all optional fields so instead of sending empty strings if they're not set, don't include them in the request at all.
MerchantReference, TxnId, TxnData1, TxnData2, and TxnData3 are all optional fields so instead of sending empty strings if they're not set, don't include them in the request at all.
|
When I branched, it already included my PxPost changes. Once the PxPost changes have been merged, I'll resubmit the PxPay changes. Sorry. |
|
@gdhnz thanks for this! Can you add some tests to cover it, please? |
|
Is updating testCompletePurchaseWithTransactionDataSuccess in PxPayCompletePurchaseSuccess.php with additional response tests for TxnData1, TxnData2, and TxnData3 enough? I can also add tests to testAuthorizeWithTransactionDataSuccess to check the request. |
Tests added to testAuthorizeWithTransactionDataSuccess to check the request and to testCompletePurchaseWithTransactionDataSuccess to check the response.
Add PxPay test if cardReference, pxPostUsername, and pxPostPassword are set.
|
Merged. Can someone please confirm that this works in production and then I will tag for release? |
|
I've confirmed this works in production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MerchantReference, TxnId, TxnData1, TxnData2, and TxnData3 are all optional fields so instead of sending empty strings if they're not set, don't include them in the request at all.