Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 RC #73

Merged
merged 89 commits into from Mar 11, 2016
Merged

v2.0.0 RC #73

merged 89 commits into from Mar 11, 2016

Conversation

philipobenito
Copy link
Member

@kayladnls @localheinz @hannesvdvreken

Will have documentation ready ASAP. For now, here is a quick example bootstrap using Zend\Diactoros.

https://gist.github.com/philipobenito/b3977c5b5e30fe386c76

@philipobenito
Copy link
Member Author

@hannesvdvreken I actually toyed with this idea but ended up deciding against it, mainly because of the reasons above whereas if that was to happen I'm not sure of the use for this package as it stands. Those strategies as an extra package could just as easily be written as an extension to FastRoute, which is then a mirror of what league/route is. It's a never ending circle so I decided on the make it easier by default without going overboard with the option to change anything you want to.

@philipobenito
Copy link
Member Author

@thebigb although league/container is included, the code itself is only dependent on container-interop interfaces so that they can be swapped out, the argument here is whether league/container should be included for use by default. The reason that it is, and the reason that it will stay this way is to make the package easier to use for anybody who just wants to install and go.

philipobenito and others added 18 commits October 14, 2015 10:08
Add PSR 7 to the list of fully compatible psrs
added is_callable check, throw exception when invalid class method is…
Enhancement: Assert that request is fetched from container if not set before
Fix: Add missing $ before parameter name in docblock
Fix: Use a more specific type in docblocks
Enhancement: Assert that response is fetched from container if not set before
@cringerjs
Copy link

Docs....

@philipobenito philipobenito merged commit d7ffbdd into master Mar 11, 2016
@philipobenito philipobenito deleted the develop branch April 3, 2016 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet