New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.0.0 RC #73
v2.0.0 RC #73
Conversation
…fault from the collection
First set default strategy, then if route HAS NO strategy, set the default from the collection
@hannesvdvreken I actually toyed with this idea but ended up deciding against it, mainly because of the reasons above whereas if that was to happen I'm not sure of the use for this package as it stands. Those strategies as an extra package could just as easily be written as an extension to FastRoute, which is then a mirror of what league/route is. It's a never ending circle so I decided on the make it easier by default without going overboard with the option to change anything you want to. |
@thebigb although league/container is included, the code itself is only dependent on container-interop interfaces so that they can be swapped out, the argument here is whether league/container should be included for use by default. The reason that it is, and the reason that it will stay this way is to make the package easier to use for anybody who just wants to install and go. |
Add PSR 7 to the list of fully compatible psrs
added is_callable check, throw exception when invalid class method is…
Enhancement: Assert that request is fetched from container if not set before
Fix: Typo
Fix: Add missing $ before parameter name in docblock
Fix: Use a more specific type in docblocks
Enhancement: Assert that response is fetched from container if not set before
Fix: Rename test
Fix: Test name
Docs.... |
Added UnavailableForLegalReasonsException and test
@kayladnls @localheinz @hannesvdvreken
Will have documentation ready ASAP. For now, here is a quick example bootstrap using Zend\Diactoros.
https://gist.github.com/philipobenito/b3977c5b5e30fe386c76