Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading time estimate is inconsistent across pages #3257

Closed
tducasse opened this issue Jun 21, 2019 · 1 comment · Fixed by #3328
Closed

Reading time estimate is inconsistent across pages #3257

tducasse opened this issue Jun 21, 2019 · 1 comment · Fixed by #3328
Labels
bug always open for contribution external contributors welcome contribution is welcome!

Comments

@tducasse
Copy link

Describe the bug

The time estimate is not the same in the search results and if you go to the article.

I think some of them are right? I'd say the one in the search results seems smaller.

To Reproduce
Either:

Or:

  • go to the search bar
  • type something
  • choose an article, read the time estimate
  • click on the article, check the estimate

Expected behavior

Both estimates should be the same.

Screenshots

Screen Shot 2019-06-21 at 9 22 11 pm

Screen Shot 2019-06-21 at 9 22 21 pm

Desktop (please complete the following information):

  • OS: Mac OS Mojave 10.14.5
  • Browser: Chrome
  • Version: 75.0.3770.100
@rhymes
Copy link
Contributor

rhymes commented Jun 21, 2019

I think it's because the search results come from the search index and it hasn't probably been updated.

Nonetheless the logic here:

https://github.com/thepracticaldev/dev.to/blob/e46bd26223847e35b9de2cd57380bad12a97286f/app/assets/javascripts/utilities/buildArticleHTML.js.erb#L100-L104

should be similar to this one:

https://github.com/thepracticaldev/dev.to/blob/e46bd26223847e35b9de2cd57380bad12a97286f/app/views/articles/_single_story.html.erb#L54-L58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug always open for contribution external contributors welcome contribution is welcome!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants