-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Worker/user self delete #5698
Worker/user self delete #5698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small request otherwise this is looking good!
class SelfDeleteWorker | ||
include Sidekiq::Worker | ||
|
||
sidekiq_options queue: :high_priority, retry: 10 | ||
|
||
def perform(user_id, service = Users::Delete) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are not using this service argument can you remove it and explicitly call the service below?
Users::Delete.call(user)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, i will
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @maykonmenezes, thank you for this PR!
As a general rule don't forget to name your branches maykonmenezes/TOPIC-ISSUE_ID
in the future, you can check the contributing guide on the details.
What type of PR is this? (check all applicable)
Description
Moving user self delete job to sidekiq
Related Tickets & Documents
#5305
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?