-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rubocop complaints #5769
Merged
Merged
Fix rubocop complaints #5769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaidehijoshi
previously approved these changes
Jan 27, 2020
pr-triage
bot
added
PR: reviewed-approved
bot applied label for PR's where reviewer approves changes
and removed
PR: unreviewed
bot applied label for PR's with no review
labels
Jan 27, 2020
benhalpern
approved these changes
Jan 27, 2020
benhalpern
requested changes
Jan 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is a class mismatch in the tests
pr-triage
bot
added
PR: reviewed-changes-requested
bot applied label for PR's where reviewer requests changes
and removed
PR: reviewed-approved
bot applied label for PR's where reviewer approves changes
labels
Jan 27, 2020
Thanks @benhalpern, I might have exaggerated in the copy and pasting :D Going to fix it |
pr-triage
bot
added
PR: unreviewed
bot applied label for PR's with no review
and removed
PR: reviewed-changes-requested
bot applied label for PR's where reviewer requests changes
labels
Jan 27, 2020
maestromac
approved these changes
Jan 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
pr-triage
bot
removed
the
PR: unreviewed
bot applied label for PR's with no review
label
Jan 27, 2020
benhalpern
approved these changes
Jan 27, 2020
pr-triage
bot
added
the
PR: reviewed-approved
bot applied label for PR's where reviewer approves changes
label
Jan 27, 2020
pr-triage
bot
added
PR: merged
bot applied label for PR's that are merged
and removed
PR: reviewed-approved
bot applied label for PR's where reviewer approves changes
labels
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Some small rubocop fixes and a few less "lines too long" :)