Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenFieldView not scroll properly #8

Closed
rahulvyas opened this issue Dec 12, 2011 · 8 comments
Closed

TokenFieldView not scroll properly #8

rahulvyas opened this issue Dec 12, 2011 · 8 comments
Assignees
Labels

Comments

@rahulvyas
Copy link

To reproduce. Enter email address until the token field goes behind the keyboard. Now if you try to scroll you will get trouble scrolling it. But if you scroll by holding a token then you can scroll. But it should behave like apple's default mail composer.

@sebgie
Copy link

sebgie commented Feb 9, 2012

As far as I can see this has to do with the UILongPressRecognizer. Since the minimum press duration is 0 every touch triggers the according event. If you set the minimum press duration to 0.3 in line 798 it should work again.

798: [longPressRecognizer setMinimumPressDuration:0.3];

@thermogl
Copy link
Owner

The TIToken is now a UIControl, so it does its own touch handling.

Unfortunately, this means that you can't even scroll by touching a token.

Trying to work out a solution now and why you can't scroll when touching a UITextField.

@thermogl
Copy link
Owner

By setting delaysContentTouches to YES you can fix this issue. It's in the latest commit.

@rahulvyas
Copy link
Author

hi tom,
nice to see some fixes. I would like to request one thing that is can
we make the body part as apple's mail composer has?

Sent from my iPod

On 25-Mar-2012, at 7:27 PM, Tom Irving
reply@reply.github.com
wrote:

By setting delaysContentTouches to YES you can fix this issue. It's in the latest commit.


Reply to this email directly or view it on GitHub:
https://github.com/thermogl/TITokenFieldView/issues/8#issuecomment-4681717

@thermogl
Copy link
Owner

Can you elaborate? Which parts of the body would you like to see?

@rahulvyas
Copy link
Author

like the mail composer's body can display images as attachments and
manage text entering.

Sent from my iPod

On 25-Mar-2012, at 7:35 PM, Tom Irving
reply@reply.github.com
wrote:

Can you elaborate? Which parts of the body would you like to see?


Reply to this email directly or view it on GitHub:
https://github.com/thermogl/TITokenFieldView/issues/8#issuecomment-4681766

@thermogl
Copy link
Owner

You'll have to do that yourself, I'm afraid.

The TITokenFieldView isn't about recreating the whole mail composer, just the tokenizing field.
I'm actually trying to move everything into the TITokenField class and phase out the parent view.

@rahulvyas
Copy link
Author

I have tried many times but still no luck. Anyways thanks for creating
such a wonderful open source composer.

Sent from my iPod

On 25-Mar-2012, at 7:41 PM, Tom Irving
reply@reply.github.com
wrote:

You'll have to do that yourself, I'm afraid.

The TITokenFieldView isn't about recreating the whole mail composer, just the tokenizing field.
I'm actually trying to move everything into the TITokenField class and phase out the parent view.


Reply to this email directly or view it on GitHub:
https://github.com/thermogl/TITokenFieldView/issues/8#issuecomment-4681789

@ghost ghost assigned thermogl Apr 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants