logdirector's "Dirty Trick" just bit me.

[freckletonj]

I was struggling to configure logging for my library that uses Thespian, until I found it was because of this function, I believe:

Thespian/thespian/system/logdirector.py

Line 46 in 4a7b522

# Dirty trick here to completely re-initialize logging in this

logging.basicConfig(...) fails (for instance, you can't change format=...) unless you use the new force=True, but I'm not convinced that doesn't break something Thespian depends on, and I don't exactly understand what this hack is doing, nor why it's necessary.

I just wanted to bubble this up to your awareness.

[freckletonj]

For future reference, here is prior art within this library. I never stumbled across documentation on logging, but here are some references:

#43
https://github.com/thespianpy/Thespian/blob/master/examples/hellogoodbye.py (NOTE: logsetup.logcfg)

Here's how I solved it for my use case, of customizing the logging formatter:

logging.basicConfig(
    stream=sys.stdout,
    level=logging.DEBUG,  # Globally allow any level. Other loggers can narrow.
)
# Quiet the lib a little
logging.getLogger('Thespian').setLevel(logging.WARN)

def mk_logger(name, level):
    ''' A logger builder helper. The Thespian '''
    logger = logging.getLogger(name)
    handler = logging.StreamHandler()
    handler.setLevel(level)
    formatter = logging.Formatter('%(asctime)s %(levelname)s:%(name)s => %(message)s [%(pathname)s:%(lineno)d]')
    handler.setFormatter(formatter)
    logger.addHandler(handler)
    return logger


# Tune this libs loggers as needed
my_logger = mk_logger('actor', logging.INFO)