Tutorial levels #108
Closed
Tutorial levels #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cdsupina
commented
Sep 10, 2023
•
cdsupina
commented
- Changed input handling to be "action" based use Leafwing Input Manager
- Optional tutorial level
- phases for tracking tutorial objectives
- can be toggled on and off in character selection screen with (up and down inputs)
- only available for single player
- 3 generic tutorials for movement, attack (and protect), and special ability,
- Overhauled game ui to use hierarchy from single game ui entity
varoonp123
reviewed
Sep 11, 2023
varoonp123
reviewed
Sep 11, 2023
varoonp123
reviewed
Sep 13, 2023
varoonp123
reviewed
Sep 13, 2023
varoonp123
reviewed
Sep 20, 2023
varoonp123
reviewed
Sep 20, 2023
…cause they are used by the PlayerPlugin
…e the gate defense objective
varoonp123
reviewed
Sep 22, 2023
| } | ||
|
|
||
| #[derive(Deserialize)] | ||
| pub struct InputBindings { |
There was a problem hiding this comment.
Suggested change
| pub struct InputBindings { | |
| struct InputBindings { |
There was a problem hiding this comment.
varoonp123
reviewed
Sep 22, 2023
varoonp123
reviewed
Sep 22, 2023
Comment on lines
+254
to
+266
| ..default() | ||
| }); | ||
| } | ||
| } | ||
| } | ||
| }); | ||
| }); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
varoonp123
reviewed
Sep 22, 2023
There was a problem hiding this comment.
The other files are < 1k so i dont really care if they are in git. This sound file should be in S3 though.
varoonp123
reviewed
Sep 22, 2023
Comment on lines
+13
to
+28
| pub player_data: Vec<Option<PlayerData>>, | ||
| } | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| pub struct PlayerData { | ||
| pub character: CharacterType, | ||
| pub input: PlayerInput, | ||
| } | ||
|
|
||
| impl Default for PlayersResource { | ||
| fn default() -> Self { | ||
| PlayersResource { | ||
| player_data: vec![None, None, None, None], | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
PlayersResource doesnt make any sense to me. Why is it Vec<Option<_>>? Why is the default 4 nones?
There was a problem hiding this comment.
It's for Nones for up to for possible players in the game. When a player slot is filled it becomes Some(PlayerData) for that slot.
varoonp123
reviewed
Sep 22, 2023
Comment on lines
+8
to
+12
| pub struct MobReachedBottomGateEvent { | ||
| pub mob_type: Option<MobType>, | ||
| pub mob_segment_type: Option<MobSegmentType>, | ||
| pub defense_interaction: DefenseInteraction, | ||
| } |
There was a problem hiding this comment.
Hmm. Lets talk about this type. Should this have an enum? Or just an Entity? 2 options seems odd.
…player module in implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.