Nit/rustc warnings20240222 #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varoonp123
force-pushed
the
nit/rustcWarnings20240222
branch
from
3603203
to
3309182
Compare
…er_stats. Bevy reexports the tracing module rather than reexporting the logging macros in the prelude. The existing import locations for the bevy tracing macros was deprecated/changed in v0.12
varoonp123
force-pushed
the
nit/rustcWarnings20240222
branch
from
3309182
to
df22088
Compare
…e redundant imports and make imports more explicit by replacing star imports with each individual item
varoonp123
force-pushed
the
nit/rustcWarnings20240222
branch
from
df22088
to
75d8c3d
Compare
…m-level imports. Especially modules with many star imports. These have caused more rustc warnings over time. And star imports are generally bad since the pollute the namespace and make imports order-dependent
varoonp123
force-pushed
the
nit/rustcWarnings20240222
branch
from
059d939
to
b254bc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run the nightly toolchain (including clippy) and require compilation without warnings (atleast for 1 kind of build). So once in a while, the build will break because rustc warns about more things.
This pr makes names more explicit.
I need to merge this so #158 can build+merge